Skip to content

Fix fog-of-war edge redraw crashes - #4

Merged
ZivDero merged 4 commits into
OpenTS-Developers:mainfrom
Krisztiaan:fix/fogged-object-edge-redraw
Aug 28, 2026
Merged

Fix fog-of-war edge redraw crashes#4
ZivDero merged 4 commits into
OpenTS-Developers:mainfrom
Krisztiaan:fix/fogged-object-edge-redraw

Conversation

@Krisztiaan

Copy link
Copy Markdown
Contributor

Summary

  • Clip fogged-object redraws to the tactical view.
  • Use the owning house’s color converter for fogged buildings instead of treating a map cell as a converter.

Prevents out-of-bounds rendering and CellClass memory corruption during fog-of-war redraws.

Behavior and compatibility

Bug fix; intended rendering behavior is preserved.

No other changes.

Validation

  • VS2022 Win32 Debug and Release builds passed.
  • Tests passed in both configurations.
  • python manual/tools/manage.py check
  • Release tested under Wine:
    Firestorm skirmish, G_CANYON.MAP, Fog of War enabled, AI present, unit movement and aggressive edge panning; no crash.
  • Native Windows runtime testing was not performed yet!!

Documentation

manual/changes/fogged-object-edge-redraw.md.

Checklist

  • The change is focused; unrelated mechanical cleanup is separate
  • Compatibility effects and any migration are explicit
  • Validation distinguishes what passed, failed, and was not run
  • No prohibited assets, binaries, SDKs, credentials, or generated output are included

Comment thread manual/changes/fogged-object-edge-redraw.md
@github-actions

Copy link
Copy Markdown

Development builds of 0066d8c:

The links work without a GitHub account. Artifacts expire after 90 days, and this comment follows the latest successful build.

Comment thread manual/changes/fogged-object-edge-redraw.md Outdated
@ZivDero
ZivDero merged commit 6aa5bad into OpenTS-Developers:main Aug 28, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants